chore: remove underscores from menuitem and menu #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: chore
cpcallen
approved these changes
Oct 25, 2022
Comment on lines
+395
to
+397
| const keyboardEvent = e as KeyboardEvent; | ||
| if (keyboardEvent.shiftKey || keyboardEvent.ctrlKey || | ||
| keyboardEvent.metaKey || keyboardEvent.altKey) { |
There was a problem hiding this comment.
I added a note to the PR description to mention this helpful removal of anyDuringMigration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #6548
Proposed Changes
Behavior Before Change
No change
Behavior After Change
No change
Reason for Changes
Cleanup
Test Coverage
Mocha tests + opened up the playground and checked that right-click menus and dropdown menus work.
Documentation
Additional Information
Also add type narrowing checks to remove some uses of
anyDuringMigration.