chore: remove underscores from private properties and methods for names and workspace comments #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Apr 10, 2023
core/workspace_comment_svg.ts
Outdated
Comment on lines
954
to
957
| this.textarea = null; | ||
| this.foreignObject = null; | ||
| this.svgRectTarget = null; | ||
| this.svgHandleTarget = null; |
There was a problem hiding this comment.
I don't think any of these nullifications are necessary. 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #6548
Proposed Changes
Remove underscores from private property and method names. Fix uses in tests. Note that the tests are still accessing private properties. I decided not to add getters that would only exist for tests.
Stop setting properties to
nullindisposewhen not needed.Behavior Before Change
No change
Reason for Changes
Match current google style guide.