Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pinch to zoom gesture for both touch and pointer events #1536

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Support pinch to zoom gesture for both touch and pointer events #1536

merged 1 commit into from
Jan 12, 2018

Conversation

samelhusseini
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#1295

Proposed Changes

Two major proposed changes:

  • Support for pointer events (Supported on latest Chrome and Edge)
  • Support for multi-touch, zooming on pinch.

Reason for Changes

Pinch to zoom is more natural on touch devices!

Test Coverage

Tested manually on various touch devices, including:

  • Pinch to zoom using two fingers
  • Drag a block and then place another finger (should continue to drag)
  • Drag the workspace and then place another finger (should continue to drag)

Tested on:

  • Desktop Chrome
  • Desktop Firefox
  • Desktop Safari
  • Windows Internet Explorer 11
  • Windows Edge
  • Surface Book (touch)
  • IE, Chrome, Firefox and Edge
  • IOS 11
    • Safari and Chrome
    • iPhone & iPad
  • Android 8
  • One Plus 5.
  • Chrome and Firefox

Additional Information

The PR doesn't enable touch gestures by default.

Other things not in this PR, but to consider for future PRs:

  • pinches can only start within the first n ms after the touch starts.
  • a workspace drag can be "upgraded" into a pinch if done within a certain distance of another pointer and within a certain timeframe. In the hope of making it feel more "natural".

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@samelhusseini
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants