Changing root script for tests under Node. #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was: tests/jsunit/test_runner.js Now: tests/test_runner.js The webdriver & jsunit calls formerly in tests/jsunit/test_runner.js are now in function runJsUnitTestsInBrowser, in run_jsunit_tests_in_browser.js, called from tests/test_runner.js. This makes room for additional tests under Node, such as a headless.
|
Looks fine but lint is failing, probably because this file is no longer excluded. Add it to .eslintignore and you're good to go. |
|
Fixed lint via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Changing root script for tests under Node.
Was:
tests/jsunit/test_runner.jsNow:
tests/test_runner.jsThe webdriver & jsunit calls formerly in
tests/jsunit/test_runner.jsare now in functionrunJsUnitTestsInBrowser(), inrun_jsunit_tests_in_browser.js, called fromtests/test_runner.js.Reason for Changes
This makes room for additional tests under Node, such as headless and generator tests.
Test Coverage
ran
npm testfrom the root, ensuring the previous tests run exactly as before.