June 2018 release #1938

rachel-fenichel · 2018-06-26T19:57:20Z

Release notes:

Fix More package-private property violations. #1788
Add 'ordered' option to descendant getting functions. (Add 'ordered' option to descendant getting functions. #1786)
Warn if jsonInit() receives a colour attribute without a value. (Warn if jsonInit() receives a colour attribute without a value. #1795)
Create base classes for block and variable events, instead of stuffing everything into Abstract
Move events back up to core, because moving it to a separate folder was a mistake.
Removing Blockly.utils.getScale_() and usage. (Removing Blockly.utils.getScale_() and usage. #1821)
Update storage.py to use ndb instead of db.
Add a referencesVariables function to field
Use named properties on Msg.
Comments v3 (Comments v3 #1817)
Add comments explaining unique IDs on clip paths
Using %{BKY_} notation for toolbox category colours. (Using %{BKY_} notation for toolbox category colours. #1826)
Replace raw window references with goog.global.window. (Replace raw window references with goog.global.window #1818)
Changing root script for tests under Node. (Changing root script for tests under Node. #1837)
Fix a problem with scrolling on firefox
Make ui events work when block is null; test
Delay getting inverse screen CTM until needed
Do not nullify inverseScreenCTM if for some reason CTM is lost
Adding Blockly.FieldDropdown.validateOptions_() (Adding Blockly.FieldDropdown.validateOptions_() #1840)
Simplify RTL handling of '<' and '>'. (Simplify RTL handling of '<' and '>'. #1823)
Fix RTL mutators in Edge and IE
Adding gulpfile to build Node.js compatible library. (Adding gulpfile to build Node.js compatible library. #1847)
Update gesture.js
Revised references to window to solve Node issues. (Revised references to window to solve Node issues. #1856)
Don't build upon npm install. (Don't build upon npm install. #1855)
Another attempt at testing for PointerEvent. (Another attempt at testing for PointerEvent. #1870)
Use .textContent setter for field text
Performance improvements for workspace clear and load
Fix 1380
Disable ws comments in IE
Add warning message for unrecognized toolbox colour value. (PR Addwarningfix/1831 #1881)
Create and use a Blockly.BlockSvg.PathObject type
Fix undoing a drag to connect
Make event filtering stricter for events
Fix case where lack of colour attribute results in null. (Fix #1893, null colour attribute for toolbox category #1894)
Adaptive popup size for FieldDropdowns (Adaptive popup size for FieldDropdowns #1897)
Remove custom touch handling code for dropdown fields
Correct require goog.Timer statements. (Correct require goog.Timer statements. #1906)
Fixing xml.js: Always throw XML I/O errors; Support parsing in Node (Fixing xml.js: Always throw XML I/O errors; Support parsing in Node #1911)
Remove goog.Timer
Clarifying the description of the generators demo. (Clarifying the description on demo/generators/ #1919)
Removing (most) Closure from BlockFactory (Removing (most) Closure from BlockFactory #1925)
Support %{..} in flyout_button (Allow ${..} messages references in Toolbox buttons and labels. #1927) (Support %{..} in flyout_button (#1927) #1929)
Fixes to handling
```
 text content.
```
Revert changes to i18n/js_to_json.py from 4cb4b42 (Revert changes to i18n/js_to_json.py from 4cb4b42 #1935)
Updating npm dependencies. (Updating npm dependencies. #1936)

Cleanup and testing:

mark properties @Protected instead of @Private so they can be used by Blockly.BlockSvg
mark properties @Protected instead of @Private so they can be used by Blockly.RenderedConnection
mark properties @Protected instead of @Private so they can be used by Blockly.FlyoutVertical & Blockly.FlyoutHorizontal
Move block animation code to a new file and rebuild
Mark Blockly.Constants.Colour and .Lists depreacted. (Deprecate Blockly.Constants.Colour and .Lists #1797)
Correct block color reference in demos/graph (Correct block color reference in demos/graph #1794)
Reverse deprecated argument order to womtoblock in accessible.
Refactor of checkBlockColourConstant_() (Refactor of checkBlockColourConstant_() #1798)
Rebuild message files
Add comment messages
Rebuild message files with new messages
Add metadata back to qqq.json
Decompose out some functions for creating zoom controls
Fix parameter annotation
Routine recompile.
Routine recompile.
Change comment on function
Adding JsDoc @this for closure in jsonInitFactory(). (Adding JsDoc @this for closure in jsonInitFactory(). #1833)
Update comments in block_events.js
Clean-up dependencies in package.json (Clean-up dependencies in package.json #1853)
Correcting typo in comment (Correcting typo in comment (from #1857) #1866)
Add a missing require and rebuild
Adding all blocks to the compilation. (Adding all blocks to the compilation. #1877)
tests/compile/compile.sh improvements (tests/compile/compile.sh improvements #1874)
Decompose some render functions so they'll be easier to work with
Adding travis_fold logging around each test (Adding travis_fold logging around each test #1879)
Fix comment in dragged_connection_manager.js
Don't keep the list of test names separate from the dropdown
Add a comment with some context on this test.
Button to load all XML files for testing
Add some workspace comment tests
Update chromedriver version
Move a test function into utils
Rebuilding _compressed.js files. (Rebuilding _compressed.js files. #1920)
Fix case of duplicate var (i)
Add curly and space-infix-ops rules
Fix lint
Fixed typo (Fixed typo in flyout_button #1899)

… Blockly.BlockSvg

… Blockly.RenderedConnection

… Blockly.FlyoutVertical & Blockly.FlyoutHorizontal

@Protected

Mark some properties @Protected instead of @Private so they can be used by subclasses

Fix google#1788

Both are only used by the hue constants, which are already deprecated.

Rewrote Blockly.checkBlockColourConstant_(..). * Last argument is now the expected value of the constant (replacing the `removed` argument). The prevents warnings when a Msg colour constant is overridden (the correct way). * If a value for the constant is not found, do not warn (google#1790).

…mations Move block animation code to a new file and rebuild

…le#1795) * Warn if jsonInit() receives a colour attribute without a value. * Extract colour init code into function. * Adding block type name to prior warnings.

…google#1796) These namespaces use to contain the original block hue constants, but were deprecated (via comment, except for procedures) over a year ago. With the removal of those constants, the declarations were creating empty, unused objects.

…g everything into Abstract

…nt_base Create base classes for block and variable events

…as a mistake.

Move events back up to core, because moving it to a separate folder was a mistake.

…espaces. (google#1796)" (google#1809) This reverts commit 75459ab.

Rebuild message files

…essages Add comment messages and rebuild

The function only returns 1 for the two cases it was used on, making the scale multiplication a no-op.

…mment Add some workspace comment tests

See scratchfoundation/scratch-blocks#1568

Update chromedriver version

Move a test function into utils

…oogle#1911) * Improved Blockly.XML comments. * Support JSDOM as an alternate parser under Node.js * Throw standard errors instead of goog.asserts. * Adding textToDomDocument_ and override in gulpfile.

Adding a link back to the "Running JavaScript" page.

This captures changes to core/xml.js that are required by Node, since the gulpfile builds from the compressed files.

Replacing all Closure goog. library calls from BlockFactory, with the exception of the ColorPicker and the test for the warning about running without Closure. This includes (almost) all goog.provide and goog.require statements.

Expand %{..} references in toolbox <button> and <label>

Fix case of redeclared var (i) in Blockly.Block.prototype.jsonInit

Add curly and space-infix-ops rules

…code Revert breaking changes to BlockFactory

Rebuild on develop before cutting a release

googlebot · 2018-06-26T19:57:52Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

…_again Merge master to develop to make git history happy

rachel-fenichel · 2018-06-26T23:59:45Z

I'm closing this PR and replacing it with #1944 so that cherry-picks can go into a branch on Blockly instead of in my repo.

jcyang43 and others added 30 commits April 16, 2018 01:33

mark properties @Protected instead of @Private so they can be used by…

6c2d633

… Blockly.BlockSvg

mark properties @Protected instead of @Private so they can be used by…

419fe9e

… Blockly.RenderedConnection

mark properties @Protected instead of @Private so they can be used by…

7dbe0bd

… Blockly.FlyoutVertical & Blockly.FlyoutHorizontal

Move block animation code to a new file and rebuild

4e3b114

Merge pull request google#1783 from jcyang43/protectedProperties

9b3c173

Mark some properties @Protected instead of @Private so they can be used by subclasses

Fix google#1788

100af38

Merge pull request google#1789 from google/rachel-fenichel-patch-1

51d512a

Fix google#1788

Add 'ordered' option to descendant getting functions. (google#1786)

662d794

Correct block color reference in demos/graph (google#1794)

49be85b

Mark Blockly.Constants.Colour and .Lists depreacted. (google#1797)

b2cb96b

Both are only used by the hue constants, which are already deprecated.

Reverse deprecated argument order to womtoblock in accessible.

b4450b7

Merge pull request google#1787 from rachel-fenichel/feature/block_ani…

46da00d

…mations Move block animation code to a new file and rebuild

Warn if jsonInit() receives a colour attribute without a value. (goog…

2bfff4a

…le#1795) * Warn if jsonInit() receives a colour attribute without a value. * Extract colour init code into function. * Adding block type name to prior warnings.

Create base classes for block and variable events, instead of stuffin…

d8202f8

…g everything into Abstract

Remove unnecessary conditionals.

5839620

Rebuild

f23c5c0

Merge pull request google#1729 from rachel-fenichel/feature/block_eve…

e4e73e7

…nt_base Create base classes for block and variable events

Move events back up to core, because moving it to a separate folder w…

4a467ce

…as a mistake.

Merge pull request google#1808 from rachel-fenichel/event_file_churn

c3b5bb2

Move events back up to core, because moving it to a separate folder was a mistake.

Revert "Removing namespace declarations for deprecated and unused nam…

ab86926

…espaces. (google#1796)" (google#1809) This reverts commit 75459ab.

Rebuild message files

3927bd1

Merge pull request google#1813 from rachel-fenichel/rebuild_langfiles

71a30dd

Rebuild message files

Add comment messages

2a37fc8

Rebuild message files with new messages

9dfcf4a

Localisation updates from https://translatewiki.net.

d521b04

Add metadata back to qqq.json

e792be0

Merge pull request google#1814 from rachel-fenichel/feature/comment_m…

5bb9088

…essages Add comment messages and rebuild

Removing Blockly.utils.getScale_() and usage. (google#1821)

42e229f

The function only returns 1 for the two cases it was used on, making the scale multiplication a no-op.

rachel-fenichel and others added 24 commits June 7, 2018 10:05

Merge pull request google#1907 from rachel-fenichel/tests/headless_co…

b630210

…mment Add some workspace comment tests

Update chromedriver version

55dca1e

See scratchfoundation/scratch-blocks#1568

Merge pull request google#1908 from google/rachel-fenichel-patch-1

d5795b8

Update chromedriver version

Move a test function into utils

3c6a29c

Merge pull request google#1910 from rachel-fenichel/tests/move_utils

0c1de91

Move a test function into utils

Fixing xml.js: Always throw XML I/O errors; Support parsing in Node (g…

7886d24

…oogle#1911) * Improved Blockly.XML comments. * Support JSDOM as an alternate parser under Node.js * Throw standard errors instead of goog.asserts. * Adding textToDomDocument_ and override in gulpfile.

Remove goog.Timer

05fcdc3

Clarifying the description of the generators demo. (google#1919)

83d8559

Adding a link back to the "Running JavaScript" page.

Rebuilding _compressed.js files. (google#1920)

a87dcc6

This captures changes to core/xml.js that are required by Node, since the gulpfile builds from the compressed files.

Removing (most) Closure from BlockFactory (google#1925)

b4cfe26

Replacing all Closure goog. library calls from BlockFactory, with the exception of the ColorPicker and the test for the warning about running without Closure. This includes (almost) all goog.provide and goog.require statements.

Localisation updates from https://translatewiki.net.

f7e6226

Support %{..} in flyout_button (google#1927) (google#1929)

100d9f1

Expand %{..} references in toolbox <button> and <label>

Fix case of duplicate var (i)

709d31b

Merge pull request google#1930 from jollytoad/fix-duplicate-var

787baf7

Fix case of redeclared var (i) in Blockly.Block.prototype.jsonInit

Localisation updates from https://translatewiki.net.

74fda79

Add curly and space-infix-ops rules

4e2b2b9

Fix lint

5b1e249

Fixes to handling <pre> text content.

2747396

Merge pull request google#1932 from rachel-fenichel/lint/infix_curly

caac6b8

Add curly and space-infix-ops rules

Merge pull request google#1933 from AnmAtAnm/fix-blockfactory-define-…

d92e464

…code Revert breaking changes to BlockFactory

Revert changes to i18n/js_to_json.py from 4cb4b42 (google#1935)

02ea01c

Updating npm dependencies. (google#1936)

51253f9

Rebuild

5ffa912

Merge pull request google#1937 from rachel-fenichel/rebuild

29d804d

Rebuild on develop before cutting a release

rachel-fenichel added 2 commits June 26, 2018 13:30

Merge branch 'master' into master_to_develop_again

3d7a0eb

Merge pull request google#1940 from rachel-fenichel/master_to_develop…

d4a4b79

…_again Merge master to develop to make git history happy

rachel-fenichel closed this Jun 26, 2018

rachel-fenichel deleted the rc/june_2018 branch June 27, 2018 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

June 2018 release #1938

June 2018 release #1938

rachel-fenichel commented Jun 26, 2018 •

edited

Loading

googlebot commented Jun 26, 2018

rachel-fenichel commented Jun 26, 2018

June 2018 release #1938

June 2018 release #1938

Conversation

rachel-fenichel commented Jun 26, 2018 • edited Loading

Release notes:

Cleanup and testing:

googlebot commented Jun 26, 2018

rachel-fenichel commented Jun 26, 2018

rachel-fenichel commented Jun 26, 2018 •

edited

Loading