Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Part of #6325
Proposed Changes
Stop checking whether
translate3d
is supported--it's fine on all browsers in 2022.Deprecate
is3dSupported
in preparation for deleting it.Behavior Before Change
Checked for support using a variety of browser prefixes, because there was not a standard way to check.
Behavior After Change
Always assume it's supported and act accordingly.
Reason for Changes
Remove workarounds for old browser behaviour.
Test Coverage
Checked in Chrome and Firefox.
I made the change in several pieces so that I could check functionality at an intermediate point.
Documentation
None
Additional Information
We might be able to make block and workspace drag surfaces always get built, or else decide they don't improve performance and delete them entirely. Either case would be nice since it would let us reduce the number of available code paths. But that's tricky because it requires performance analysis and because the block and drag surfaces are currently optional arguments to the (public)
WorkspaceSvg
constructor.