Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internet Explorer support #6325

Closed
7 of 8 tasks
rachel-fenichel opened this issue Aug 8, 2022 · 8 comments · Fixed by #6534
Closed
7 of 8 tasks

Remove Internet Explorer support #6325

rachel-fenichel opened this issue Aug 8, 2022 · 8 comments · Fixed by #6534
Assignees
Labels
internal External contributions not accepted type: cleanup

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Aug 8, 2022

Is your feature request related to a problem? Please describe.

On June 15, 2022 Microsoft announced that "Internet Explorer 11 has retired and is officially out of support."

Supporting IE takes a decent amount of work and requires workarounds in both implementations and the build system.

Describe the solution you'd like

  • Remove uses of userAgent.IE in Blockly core.
  • Remove isIe and IE from useragent.ts
  • Remove workaround in flyout_base
  • Remove IE from test matrix (internal documentation)
  • Remove IE from PR template
  • Remove workarounds for IE in bootstrap.js
  • Remove IE workarounds from stripped-down base.js
  • Update generated target to ES6/es2015 #6328

Describe alternatives you've considered

Continue supporting IE until the heat death of the universe or 2029 (whichever comes sooner).

Additional context

This is a breaking change, although hopefully for very few end users.

@rachel-fenichel rachel-fenichel added the issue: triage Issues awaiting triage by a Blockly team member label Aug 8, 2022
@BeksOmega BeksOmega added type: cleanup internal External contributions not accepted and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 16, 2022
@rachel-fenichel
Copy link
Collaborator Author

rachel-fenichel commented Aug 23, 2022

Other places where we have workarounds for IE:

  • workspaceSvg.setBrowserFocus
  • css.ts: alternatives to cursor: grabbing;
  • xml.ts: blockToDom
  • grid.ts: update

@rachel-fenichel
Copy link
Collaborator Author

  • svg_math.ts: is3dSupported looks like it was mostly a workaround for IE not supporting CSS transforms on SVG elements. The work here is to check whether the Firefox problem still repros and delete as much of this function as possible--meaning ideally collapse it down to true and then delete it all.

@rachel-fenichel
Copy link
Collaborator Author

@rachel-fenichel
Copy link
Collaborator Author

  • utils/style.ts: getStyle, getComputedStyle, and getCascadedStyle

@rachel-fenichel
Copy link
Collaborator Author

  • utils/dom.ts: createSvgElement

@rachel-fenichel
Copy link
Collaborator Author

  • utils/dom.ts: addClass, removeClass, removeClasses, hasClass, removeNode

@rachel-fenichel
Copy link
Collaborator Author

rachel-fenichel commented Oct 3, 2022

  • css.ts: assorted workarounds for IE

@BeksOmega
Copy link
Collaborator

Closed by #6781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal External contributions not accepted type: cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants