Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove blockly factory use of utils.dom.add/removeClass #6534

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

NeilFraser
Copy link
Contributor

@NeilFraser NeilFraser commented Oct 12, 2022

utils.dom.add/removeClass is going away, now that the IE work-around it provided is no longer required.

Fixes #6325

@NeilFraser NeilFraser requested a review from a team as a code owner October 12, 2022 09:33
@NeilFraser NeilFraser requested a review from cpcallen October 12, 2022 09:33
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Oct 12, 2022
@BeksOmega
Copy link
Collaborator

Can you check that class names with spaces aren't an issue? (related: #6455)

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Oct 12, 2022

Fixes #6325

@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Oct 12, 2022
@NeilFraser
Copy link
Contributor Author

Can you check that class names with spaces aren't an issue? (related: #6455)

Confirming that spaces are not an issue in this PR; the cases here are hard-coded single word strings.

@NeilFraser NeilFraser merged commit 9b81317 into develop Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Internet Explorer support
4 participants