-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove various IE hacks and workarounds #6781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But sadly I also do not have access to a machine that can run edge :/
You can use browserstack. |
And if you don't want to use browserstack, you can push it up to a site that I can access from my personal laptop and I can follow instructions to test it. I am not set up to build blockly locally on that laptop though, and don't want to be :) |
I tested on browser stack, and Rachel tested locally! looks good =) |
The basics
npm run format
andnpm run lint
The details
Resolves
#6325, aside from base.js.
Proposed Changes
Removes various IE-specific hacks from the codebase.
Test Coverage
Ensured tests pass, and tried to poke at the affected codepaths in Chrome. It'd probably be good to verify these changes in (modern) Edge, but I don't have any machine that runs it.