Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove various IE hacks and workarounds #6781

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Conversation

gonfunko
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6325, aside from base.js.

Proposed Changes

Removes various IE-specific hacks from the codebase.

Test Coverage

Ensured tests pass, and tried to poke at the affected codepaths in Chrome. It'd probably be good to verify these changes in (modern) Edge, but I don't have any machine that runs it.

@gonfunko gonfunko requested a review from a team as a code owner January 18, 2023 21:05
@gonfunko gonfunko requested a review from cpcallen January 18, 2023 21:05
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Jan 18, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen January 18, 2023 21:07
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But sadly I also do not have access to a machine that can run edge :/

@rachel-fenichel
Copy link
Collaborator

You can use browserstack.

@rachel-fenichel
Copy link
Collaborator

And if you don't want to use browserstack, you can push it up to a site that I can access from my personal laptop and I can follow instructions to test it. I am not set up to build blockly locally on that laptop though, and don't want to be :)

@BeksOmega
Copy link
Collaborator

I tested on browser stack, and Rachel tested locally! looks good =)

@gonfunko gonfunko merged commit 17064a1 into google:develop Mar 14, 2023
@gonfunko gonfunko deleted the ie branch March 14, 2023 18:26
@BeksOmega BeksOmega mentioned this pull request Mar 17, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants