feat: connection highlighting in geras and thrasos #7698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
changed the title
github-actions
bot
added
PR: feature
cpcallen
reviewed
Dec 11, 2023
cpcallen
approved these changes
Dec 12, 2023
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
* chore: move connection highlighting into the geras renderer * chore: remove IConnectionHighlighter interface * chore: format * chore: fixup * chore: format * fix: PR comments
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
* chore: move connection highlighting into the geras renderer * chore: remove IConnectionHighlighter interface * chore: format * chore: fixup * chore: format * fix: PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes
Adds logic to geras and thrasos to highlight their connections.
Added logic to the base renderer to support code reuse.
Removed the interface since I added the logic to the base renderer.
Reason for Changes
Needed to move highlighting logic to the renderer so it can differ on a renderer-by-renderer-basis.
Test Coverage
Tested that connections in thrasos and geras are still properly highlighted.
Documentation
N/A
Additional Information
N/A