Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the dynamic connections plugin without hacky monkey-patching. #7204

Closed
1 task done
johnnesky opened this issue Jun 23, 2023 · 2 comments · Fixed by google/blockly-samples#2204
Closed
1 task done

Support the dynamic connections plugin without hacky monkey-patching. #7204

johnnesky opened this issue Jun 23, 2023 · 2 comments · Fixed by google/blockly-samples#2204
Assignees
@BeksOmega
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@johnnesky
Copy link
Member

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

The block-dynamic-connection plugin monkey-patches Blockly.InsertionMarkerManager. It adds a new property, pendingBlocks, and overrides the update and dispose methods, but there's no facility to provide an alternative implementation of the interface so it has to fall back on monkey-patching.

Additionally, my PR to migrate the plugin to TypeScript uses hacky syntax (square brackets) to access private methods, which maybe could be made protected instead. google/blockly-samples#1719

Request

Design and implement support for the dynamic connections plugin and similar plugins. The plugin logic can be modified too if necessary.

Alternatives considered

No response

Additional context

No response
@johnnesky johnnesky added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jun 23, 2023
@johnnesky johnnesky mentioned this issue Jun 23, 2023
Merged
@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 28, 2023
@maribethb maribethb added this to the Upcoming milestone Jun 28, 2023
@maribethb maribethb removed this from the Upcoming milestone Sep 27, 2023
@BeksOmega
Copy link
Collaborator

Related stuff about reindeer connections: microsoft/pxt-blockly#287

This was referenced Nov 9, 2023
Merged
Merged
@BeksOmega BeksOmega mentioned this issue Dec 6, 2023
Merged
1 task
@BeksOmega BeksOmega mentioned this issue Jan 11, 2024
Merged
1 task
This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 2, 2024
Merged
Merged
@BeksOmega
Copy link
Collaborator

Closed by google/blockly-samples#2190

@maribethb maribethb mentioned this issue Feb 16, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeksOmega BeksOmega

Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: use new connection previewer in block-dynamic-connection google/blockly-samples
3 participants
@maribethb @BeksOmega @johnnesky