fix: have connection previewer use the registry #7800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/use-registry-connection-previewer
branch
from
d2bedfa to
0183a06
Compare
maribethb
approved these changes
Jan 26, 2024
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes + reasons
Makes it so the block dragger accesses the previewer class from the registry, so that it is possible for folks to provide their own connection previewers. The InsertionMarkerPreviewer registers itself as the default connection previewer.
Test Coverage
All tests pass. Insertion markers continue to be created.
Documentation
Filed a tracking task against myself for documenting connection previewers.
Additional Information
Dependent on #7797