fix: deprecate insertion marker and related methods #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
PR: fix
BeksOmega
force-pushed
the
fix/deprecate-insertion-marker-manager
branch
from
4cc43ef to
30f389b
Compare
BeksOmega
force-pushed
the
fix/deprecate-insertion-marker-manager
branch
from
30f389b to
511ed16
Compare
cpcallen
approved these changes
Jan 26, 2024
| @@ -56,6 +56,8 @@ const DUPLICATE_BLOCK_ERROR = | |||
| * Class that controls updates to connections during drags. It is primarily | |||
| * responsible for finding the closest eligible connection and highlighting or | |||
| * unhighlighting it as needed during a drag. | |||
| * | |||
| * @deprecated v10 - Use an IConnectionPreviewer instead. | |||
There was a problem hiding this comment.
Are you expecting to merge connection-previewers into develop and see it released as a future v10.x release?
There was a problem hiding this comment.
yes! should go out mid quarter.
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
github-actions
bot
added
PR: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes
Deprecates the insertion marker manager.
Reason for Changes
We aint using it no more.
Test Coverage
All tests pass
Documentation
N/A
Additional Information
Dependent on #7793
Deprecation
The
InsertionMarkerManagerhas been deprecated. All of the methods on this class were marked@internalso they shouldn't have been being accessed. If you were accessing them, the new system that replaced this class is called connection previewers.