Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Issue#8348 #8385

Closed
wants to merge 7 commits into from
Closed

Fix: Issue#8348 #8385

wants to merge 7 commits into from

Conversation

Harsh-svg988
Copy link

The basics

The details

Resolves

Fixes #8348

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

dependabot bot and others added 7 commits July 10, 2024 15:45
@dependabot
chore(deps): bump @typescript-eslint/eslint-plugin from 7.12.0 to 7.1…
0e85c71 
…6.0 (#8296)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.12.0 to 7.16.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@gonfunko
fix: use the correct with in getBoundingRectangleWithoutChildren().
b0169ab
@gonfunko
Merge pull request #8298 from gonfunko/width-fix
f8025a1 
fix: use the correct with in getBoundingRectangleWithoutChildren().
@dependabot @johnnesky
chore(deps): bump typescript from 5.4.3 to 5.5.3 (#8239)
baadb52 
* chore(deps): bump typescript from 5.4.3 to 5.5.3

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.4.3 to 5.5.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.4.3...v5.5.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: Update typescript and an indirect dependency for compatibility.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Nesky <johnnesky@gmail.com>
@dependabot
chore(deps): bump mocha from 10.2.0 to 10.6.0 (#8364)
e634b51 
Bumps [mocha](https://github.com/mochajs/mocha) from 10.2.0 to 10.6.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v10.2.0...v10.6.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@changminbark
fix: added id to rendered ws comments; made getCommentById public; ad…
4cdca28 
…ded blocklyDraggable class to ws comments (#8358)
@Harsh-svg988
fix: This commit resolves issue #8348
f607aaa
@Harsh-svg988 Harsh-svg988 requested a review from a team as a code owner July 16, 2024 19:43
@Harsh-svg988 Harsh-svg988 requested a review from cpcallen July 16, 2024 19:43
@google-cla Google CLA
Copy link

google-cla bot commented Jul 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions[bot]
github-actions bot reviewed Jul 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 17, 2024 16:52
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Jul 17, 2024
@cpcallen
Copy link
Contributor

@BeksOmega You reassigned this between when I clicked on it in my list of assigned PRs and when the tab opened on the PR itself. 😵‍💫

@BeksOmega
Copy link
Collaborator

Heya @Harsh-svg988 It looks like you have some extra commits in this branch! To remove the commits that aren't yours, you can rebase your branch on top of the latest rc/v12.0.0 branch. This will remove any commits that were added to rc/v12.0.0 since you created your branch.

Here are the steps to do that:

  1. Fetch the latest changes from rc/v12.0.0:

    git fetch upstream rc/v12.0.0

  2. Checkout your branch:

    git checkout [your-branch-name]

  3. Start an interactive rebase:

    git rebase -i upstream/rc/v12.0.0

  4. In the editor that opens, identify the commits that aren't yours. These are likely the ones at the top of the list.

  5. Change the word pick to drop for each commit you want to remove.

  6. Save and close the editor.

  7. Force push your changes to your branch: Note that force pushing is a dangerous operation because it overwrites commit history, so if you dropped the wrong commits you could lose work.

    git push -f origin [your-branch-name]

Once you've done this, the PR should only contain your commits.

Let me know if you have any questions or run into any issues!

BeksOmega
BeksOmega requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested.

@BeksOmega
Copy link
Collaborator

@Harsh-svg988 Are you still interested in working on this?

@BeksOmega BeksOmega closed this Jul 27, 2024
@harsh-791
Copy link

@BeksOmega Can i work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@BeksOmega BeksOmega BeksOmega requested changes

Assignees

@BeksOmega BeksOmega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Harsh-svg988 @cpcallen @BeksOmega @harsh-791 @gonfunko @changminbark