Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue#8348 #8385

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/block_svg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ export class BlockSvg
getBoundingRectangleWithoutChildren(): Rect {
return this.getBoundingRectangleWithDimensions({
height: this.height,
width: this.width,
width: this.childlessWidth,
});
}

Expand Down
2 changes: 1 addition & 1 deletion core/comments/comment_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class CommentView implements IRenderedElement {

constructor(private readonly workspace: WorkspaceSvg) {
this.svgRoot = dom.createSvgElement(Svg.G, {
'class': 'blocklyComment blocklyEditable',
'class': 'blocklyComment blocklyEditable blocklyDraggable',
});

this.highlightRect = this.createHighlightRect(this.svgRoot);
Expand Down
1 change: 1 addition & 0 deletions core/comments/rendered_workspace_comment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class RenderedWorkspaceComment
// Set the size to the default size as defined in the superclass.
this.view.setSize(this.getSize());
this.view.setEditable(this.isEditable());
this.view.getSvgRoot().setAttribute('data-id', this.id);

this.addModelUpdateBindings();

Expand Down
6 changes: 3 additions & 3 deletions core/toolbox/category.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export class ToolboxCategory
'label': 'blocklyTreeLabel',
'contents': 'blocklyToolboxContents',
'selected': 'blocklyTreeSelected',
'openicon': 'blocklyTreeIconOpen',
'openicon': 'blocklyToolboxCategoryIconOpen',
'closedicon': 'blocklyTreeIconClosed',
};
}
Expand Down Expand Up @@ -708,11 +708,11 @@ Css.register(`
background-position: 0 -17px;
}

.blocklyTreeIconOpen {
.blocklyToolboxCategoryIconOpen {
background-position: -16px -1px;
}

.blocklyTreeSelected>.blocklyTreeIconOpen {
.blocklyTreeSelected>.blocklyToolboxCategoryIconOpen {
background-position: -16px -17px;
}

Expand Down
1 change: 0 additions & 1 deletion core/workspace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,6 @@ export class Workspace implements IASTNodeLocation {
*
* @param id ID of comment to find.
* @returns The sought after comment, or null if not found.
* @internal
*/
getCommentById(id: string): WorkspaceComment | null {
return this.commentDB.get(id) ?? null;
Expand Down
Loading
Loading