Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI #299

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add GitHub Actions CI #299

merged 1 commit into from
Sep 9, 2024

Conversation

derekmauro
Copy link
Member

No description provided.

@derekmauro derekmauro requested a review from dinord September 9, 2024 18:06
Copy link
Collaborator

@dinord dinord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉

--show_timestamps
--test_env="TZDIR=${GITHUB_WORKSPACE}/testdata/zoneinfo"
--test_output=errors
--test_tag_filters=-benchmark
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have open source benchmarks, it would be good to at least build them.
Do we still build them with this flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do build them.

pull_request:

env:
BAZEL_CXXOPTS: -std=c++14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we'll add more language versions in the future--I'd leave a TODO here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replicates the current build. I'll expand this in the future.

@derekmauro derekmauro merged commit 6624659 into google:master Sep 9, 2024
9 checks passed
@derekmauro derekmauro deleted the actions branch September 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants