Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI #299

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
name: ci

on:
push:
pull_request:

env:
BAZEL_CXXOPTS: -std=c++14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we'll add more language versions in the future--I'd leave a TODO here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replicates the current build. I'll expand this in the future.


jobs:
Linux-GCC:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Tests
run: >
bazel test ...
--copt=-DGTEST_REMOVE_LEGACY_TEST_CASEAPI_=1
--copt=-Werror
--cxxopt=-Wall
--cxxopt=-Wextra
--cxxopt=-Wcast-qual
--cxxopt=-Wconversion-null
--cxxopt=-Wformat-security
--cxxopt=-Wmissing-declarations
--cxxopt=-Wnon-virtual-dtor
--cxxopt=-Woverlength-strings
--cxxopt=-Wpointer-arith
--cxxopt=-Wundef
--cxxopt=-Wunused-local-typedefs
--cxxopt=-Wunused-result
--cxxopt=-Wvarargs
--cxxopt=-Wvla
--cxxopt=-Wwrite-strings
--cxxopt=-Wno-missing-declarations
--cxxopt=-Wno-undef
--features=external_include_paths
--keep_going
--show_timestamps
--test_env="TZDIR=${GITHUB_WORKSPACE}/testdata/zoneinfo"
--test_output=errors
--test_tag_filters=-benchmark
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have open source benchmarks, it would be good to at least build them.
Do we still build them with this flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do build them.


Linux-Clang:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Tests
run: >
bazel test ...
--action_env=CC=clang
--copt=-DGTEST_REMOVE_LEGACY_TEST_CASEAPI_=1
--copt=-Werror
--cxxopt=-Wall
--cxxopt=-Wextra
--cxxopt=-Wc++98-compat-extra-semi
--cxxopt=-Wcast-qual
--cxxopt=-Wconversion
--cxxopt=-Wdeprecated-pragma
--cxxopt=-Wfloat-overflow-conversion
--cxxopt=-Wfloat-zero-conversion
--cxxopt=-Wfor-loop-analysis
--cxxopt=-Wformat-security
--cxxopt=-Wgnu-redeclared-enum
--cxxopt=-Winfinite-recursion
--cxxopt=-Winvalid-constexpr
--cxxopt=-Wliteral-conversion
--cxxopt=-Wmissing-declarations
--cxxopt=-Woverlength-strings
--cxxopt=-Wpointer-arith
--cxxopt=-Wself-assign
--cxxopt=-Wshadow-all
--cxxopt=-Wshorten-64-to-32
--cxxopt=-Wsign-conversion
--cxxopt=-Wstring-conversion
--cxxopt=-Wtautological-overlap-compare
--cxxopt=-Wtautological-unsigned-zero-compare
--cxxopt=-Wuninitialized
--cxxopt=-Wunreachable-code
--cxxopt=-Wunused-comparison
--cxxopt=-Wunused-local-typedefs
--cxxopt=-Wunused-result
--cxxopt=-Wvla
--cxxopt=-Wwrite-strings
--cxxopt=-Wno-unknown-warning-option
--cxxopt=-Wno-undef
--features=external_include_paths
--keep_going
--show_timestamps
--test_env="TZDIR=${GITHUB_WORKSPACE}/testdata/zoneinfo"
--test_output=errors
--test_tag_filters=-benchmark

macOS:
runs-on: macos-latest
steps:

- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Tests
run: >
bazel test ...
--features=external_include_paths
--keep_going
--show_timestamps
--test_env="TZDIR=${GITHUB_WORKSPACE}/testdata/zoneinfo"
--test_output=errors
--test_tag_filters=-benchmark

Windows:
runs-on: windows-latest
steps:

- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Tests
run: >
bazel test ...
--keep_going
--show_timestamps
--test_env="TZDIR=$env:GITHUB_WORKSPACE\testdata\zoneinfo"
--test_output=errors
--test_tag_filters=-benchmark