Updates to cel-go proto equality to mirror C++ MessageDifferencer #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
force-pushed
the
proto-equals
branch
from
0eae061 to
252d283
Compare
TristonianJones
requested review from
jcking
and removed request for
jnthntatum
Merged
jcking
requested changes
Feb 15, 2022
jcking
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few small changes to how proto equality functions with CEL to ensure
that the same definition of equality is used consistently between cel-go, cel-cpp, and cel-java.
Additionally, the changes for proto equality have already been enabled in the latest version of the
cel-spec which can be observed from the WORKSPACE update.
Note, the
LICENSEhas been updated to indicate that theproto.Equalimplementation wasderived within the
pb.gofile. This should have no material impact on how CEL is licensed though.