Heterogeneous equality #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this PR should only be submitted after #481 is merged. |
TristonianJones
force-pushed
the
heterogeneous-equality
branch
from
db69949 to
8ef2219
Compare
|
PTAL |
jcking
reviewed
Feb 22, 2022
jcking
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable heterogeneous equality within the runtime.
The type-checker will raise errors when cross-type comparisons are made within strongly typed
expressions; however, for dynamically typed data such inferences are not possible meaning they
must be handled appropriately at runtime.
Heterogeneous equality is being introduced to ensure that CEL and proto equality are better
aligned, that CEL's notion of runtime equality is consistent with Zeta SQLs, and to make it easier
to work with dynamically typed data: e.g.
json.string_value != 2This change is a semantic change which has not yet been reflected in the cel-spec but will be
soon. The change is generally regarded as safe as it shifts error states to non-error states, but
in very rare circumstances it is possible that an application may rely on this error to be produced.