Create initial Appveyor configuration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruton
force-pushed
the
appveyor-ci
branch
8 times, most recently
from
ca76c82
to
086b98e
Compare
nmittler
reviewed
Jan 11, 2017
|
|
||
| return count; | ||
| } | ||
| int vasprintf(char **ret, const char *format, va_list args); |
There was a problem hiding this comment.
Where are the definitions of these methods? Were they moved?
There was a problem hiding this comment.
It looks like you put them in JNIHelp.cpp in commit 73246d3
There was a problem hiding this comment.
oh weird ... I don't think that makes sense. Would you mind backing that out? I think keeping them inline here is better. WDYT?
Change-Id: Iddbb49825719ab1aaa3b879a0faf6525cc09e840
|
Yay. |
Change-Id: I331a40162722d366f1b73f523450641a440af0d8
nmittler
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will build with Windows to make sure that doesn't break.