-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matchers.booleanConstant(true) should _not_ match Boolean.FALSE #1454
Comments
carterkozak
added a commit
to carterkozak/error-prone
that referenced
this issue
Dec 17, 2019
PR here: #1455 |
Merged
kluever
pushed a commit
that referenced
this issue
Dec 18, 2019
Boolean.FALSE Fixes #1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
kluever
pushed a commit
that referenced
this issue
Dec 18, 2019
Boolean.FALSE Fixes #1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this issue
Feb 19, 2020
Boolean.FALSE Fixes google#1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem / feature request:
booleanConstant(true)
should not match bothBoolean.TRUE
andBoolean.FALSE
.Feature requests: what underlying problem are you trying to solve with this feature?
Matchers match code that they're build specifically not to match.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Writing tests.
What version of Error Prone are you using?
2.3.4
Have you found anything relevant by searching the web?
no
The text was updated successfully, but these errors were encountered: