MOE Sync 2019-12-18 #1456
MOE Sync 2019-12-18 #1456
Conversation
…enerated *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=285998243
Boolean.FALSE Fixes #1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
Do not match methods of anonymous classes. Those methods can't be overriden because those classes can't be extended. Do not match methods of certain enum classes. It is not possible to override the methods of an enum class except in the (anonymous) class bodies of its enum constants. If all the enum constants lack class bodies, then the enum class's methods can't be overridden. Fix cases where the bug pattern would become confused about the receiver of unqualified or this-qualified method invocations, and where it would wrongly conclude that the method belonged to the instance under construction and issue a warning. Support @SuppressWarnings("ConstructorInvokesOverridable") on more Fixes #1449 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286077091
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
ExtendsAutoValue: walk up the tree to see if an enclosing class is @generated
e05fa7a
Fix #1454: Matchers.booleanConstant(true) doesn't match Boolean.FALSE
Fixes #1455
3ad1714
ConstructorInvokesOverridable: fix some false positives
Do not match methods of anonymous classes. Those methods can't be
overriden because those classes can't be extended.
Do not match methods of certain enum classes. It is not possible to
override the methods of an enum class except in the (anonymous) class
bodies of its enum constants. If all the enum constants lack class
bodies, then the enum class's methods can't be overridden.
Fix cases where the bug pattern would become confused about the receiver
of unqualified or this-qualified method invocations, and where it would
wrongly conclude that the method belonged to the instance under
construction and issue a warning.
Support @SuppressWarnings("ConstructorInvokesOverridable") on more
Fixes #1449
41132da