Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parent directory before writing patch file #1070

Conversation

AlexandreCarlton
Copy link
Contributor

We may choose to place the generated error-prone.patch file in a
subdirectory of the base which might not already exist. For example, we
may wish to place it in target/patches instead of the base directory.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

We may choose to place the generated `error-prone.patch` file in a
subdirectory of the base which might not already exist. For example, we
may wish to place it in target/patches instead of the base directory.
@AlexandreCarlton AlexandreCarlton force-pushed the create-patch-file-directory-before-writing branch from 3e353ac to 615f093 Compare July 14, 2018 10:55
@AlexandreCarlton
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

kluever pushed a commit that referenced this pull request May 17, 2020
We may choose to place the generated `error-prone.patch` file in a
subdirectory of the base which might not already exist. For example, we
may wish to place it in target/patches instead of the base directory.

Fixes #1070

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311908270
@kluever kluever mentioned this pull request May 17, 2020
kluever pushed a commit that referenced this pull request May 17, 2020
We may choose to place the generated `error-prone.patch` file in a
subdirectory of the base which might not already exist. For example, we
may wish to place it in target/patches instead of the base directory.

Fixes #1070

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311908270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants