MOE Sync 2020-05-17 #1618
MOE Sync 2020-05-17 #1618
Conversation
RELNOTES: Don't flag module-info.java for not having default package ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311760553
see #1106 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311771528
…ify chain. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311796615
Fixes #1110 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311825676
Fixes #1187 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311831016
This flag turns off all WARNING-level checks, while leaving on those at ERROR level. This is useful for those who want to compile with -Werror but don't want any EP WARNING-level issue to block the build. Individual WARNING level checks can still be set to ERROR level as desired. Fixes #785 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311831028
JDK 12 changes the representation of labelled breaks to use an identifier for the label (instead of just a name), and the identifier doesn't have a symbol. Fixes #1111 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311832221
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311844374
We may choose to place the generated `error-prone.patch` file in a subdirectory of the base which might not already exist. For example, we may wish to place it in target/patches instead of the base directory. Fixes #1070 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311908270
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Don't flag module-info.java for not having default package
RELNOTES: Don't flag module-info.java for not having default package
7be2c43
Initial support for JDK versions through 13
see #1106
8de8a63
Ignore hanging return values when invoking a graph method in graphVerify chain.
d7e7819
GuardedByUtils: return empty set instead of null
Fixes #1110
8f05406
Add a note about other annotation processors to the maven example
Fixes #1187
544b2b7
Add -XepDisableAllWarnings flag
This flag turns off all WARNING-level checks, while leaving on those at ERROR level. This is useful for those who want to compile with -Werror but don't want any EP WARNING-level issue to block the build. Individual WARNING level checks can still be set to ERROR level as desired.
Fixes #785
0202733
Add a null-check in CanBeStatic
JDK 12 changes the representation of labelled breaks to use an identifier for
the label (instead of just a name), and the identifier doesn't have a symbol.
Fixes #1111
12e2544
Fix typo
RELNOTES: N/A
161dfb3
Create parent directory before writing patch file
We may choose to place the generated
error-prone.patchfile in asubdirectory of the base which might not already exist. For example, we
may wish to place it in target/patches instead of the base directory.
Fixes #1070
1d36bc0