Have Refaster resolve classes against the appropriate modules #1239
Conversation
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, but fail on JDK 9+. See google#1239
|
@lowasser would it be possible to have this change merged in time for the next release? Without it a significant portion of Refaster templates simply don't match on JDK 9+. |
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, but fail on JDK 9+. See google#1239
Stephan202
force-pushed
the
bugfix/refaster-on-jdk-9-plus
branch
from
6a00996 to
2cc5fe4
Compare
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, but fail on JDK 9+.
Stephan202
force-pushed
the
bugfix/refaster-on-jdk-9-plus
branch
from
2cc5fe4 to
b3ee169
Compare
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, but fail on JDK 9+. See google#1239
|
Does this effectively mean that I cannot use Refaster in a Java 11 code base, where I also want to write Refaster rules pertaining to the types in said code base? |
|
@knutwannheden indeed, many interesting Refaster rules will not match without these changes. I wonder whether inside Google no code has been migrated to Java 9+ yet, because otherwise they should have hit this same issue 🤔 . Within our company we work around this issue (and a small number of others) by maintaining a fork. It is available on Jitpack. I tagged version |
|
@Stephan202 Thanks for the heads up. I am new to Refaster and it took me a while to find this PR. I thought I had hit some corner case with generics. I will give your fork a try. Thanks for the tip! |
|
@Stephan202 Using your forked error-prone build I was indeed able to write and apply Refaster rules against Java 11 code. Very nice! Now it would be nice if this PR could also be integrated... |
|
This bit us, too. It seemed like refaster just wasn't working due to lack of any obvious error. I had to spend a while spelunking through refaster to find what was wrong, and had created a band-aid fix before seeing this PR. It'd be great to get this merged, as more of the world moves to JDK 9+. |
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, Fixes #1239 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303219121
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, Fixes #1239 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303219121
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, Fixes #1239 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303219121
Looking up classes only in java.base seems to work fine on JDK 8, but fails on
JDK 9+. This causes Refaster templates that reference non-JDK types to silently
not match in places where they should. By resolving classes against the
appropriate modules the problem goes away.
Prior to this change the newly added test would pass when executed on JDK 8,
but fail on JDK 9+.