MOE Sync 2020-03-27 #1550
MOE Sync 2020-03-27 #1550
Conversation
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303150947
Looking up classes only in java.base seems to work fine on JDK 8, but fails on JDK 9+. This causes Refaster templates that reference non-JDK types to silently not match in places where they should. By resolving classes against the appropriate modules the problem goes away. Prior to this change the newly added test would pass when executed on JDK 8, Fixes #1239 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303219121
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLA:yes from #1239 |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
Forgot to merge this, replaced by #1551 |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Simplify SuggestedFix creation using the static factories.
76852fc
Have Refaster resolve classes against the appropriate modules
Looking up classes only in java.base seems to work fine on JDK 8, but fails on
JDK 9+. This causes Refaster templates that reference non-JDK types to silently
not match in places where they should. By resolving classes against the
appropriate modules the problem goes away.
Prior to this change the newly added test would pass when executed on JDK 8,
Fixes #1239
cb344d8