MOE Sync 2020-01-06 #1465
Merged
MOE Sync 2020-01-06 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ely,} final. This seems common and fiddly enough to be useful. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287826152
…in its blast radius. Fixes external #1451 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287828341
RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287838890
Fixes external [#1428](#1428). The test is from the linked PR, but the implementation is not. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287865214
RELNOTES: DurationToLongTimeUnit now finds mismatches when using something(TimeUnit.FOO.convert(Duration), NOT_FOO); ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287881740
This avoids doing a little work for non-class symbols. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287885724
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287887267
Fixes external #1447 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287975763
…do some memoizing. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287976155
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287977884
Remove an unnecessary labelled loop. Reformat some tests a little. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287979486
RELNOTES: PreferJavaTimeOverload is off by default. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288028847
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288292908
I fat-fingered this in the earlier commit. Let's have a test, too. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288298756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Add a helper to ASTHelpers for checking whether a symbol is {effectively,} final.
This seems common and fiddly enough to be useful.
cbf5ec7
Stop renameMethodInvocation from renaming any matching arguments within its blast radius.
Fixes external #1451
4aa8c19
Do some minor refactoring in DurationToLongTimeUnit.
e518b4e
InterruptedExceptionSwallowed: handle rethrown exceptions properly.
Fixes external #1428. The test is from the linked PR, but the implementation is not.
60de2dc
Inspect TimeUnit.convert(Duration) for mismatches.
RELNOTES: DurationToLongTimeUnit now finds mismatches when using
something(TimeUnit.FOO.convert(Duration), NOT_FOO);
3eb5709
Reorder some Optional handling
This avoids doing a little work for non-class symbols.
4213c4a
Improve handling of AutoCloseable
f3fee80
TryFailRefactoring: don't NPE if there's no enclosing method.
Fixes external #1447
7040b51
AbstractReturnValueIgnored: avoid recreating Matchers for each call; do some memoizing.
b3e4fae
StronglyTypeDuration: generalise to Instant, Joda types, and proto time.
3440c9a
Fix some Javadoc in StaticImports.
Remove an unnecessary labelled loop. Reformat some tests a little.
d97e683
Disable PreferJavaTimeOverload by default in Error Prone.
RELNOTES: PreferJavaTimeOverload is off by default.
08c4793
InterruptedExceptionSwallowed: handle try with resources better.
b7f2a6e
Fix method reference void check.
I fat-fingered this in the earlier commit. Let's have a test, too.
e7c3e3c