Code

MOE Sync 2020-01-06#1465

Code

Merged

netdpb merged 14 commits intomastergoogle/error-prone:masterfrom sync-master-2020/01/06google/error-prone:sync-master-2020/01/06Copy head branch name to clipboardJan 6, 2020

+724-285

Commits

Commits on Jan 6, 2020

• Add a helper to ASTHelpers for checking whether a symbol is {effectively,} final.

  Show description for cbf5ec7
  

  graememorgan

  authored and

  netdpb

  committed
  cbf5ec7

• Stop renameMethodInvocation from renaming any matching arguments within its blast radius.

  Show description for 4aa8c19
  

  graememorgan

  authored and

  netdpb

  committed
  4aa8c19

• Do some minor refactoring in DurationToLongTimeUnit.

  Show description for e518b4e
  

  nick-someone

  authored and

  netdpb

  committed
  e518b4e

• InterruptedExceptionSwallowed: handle rethrown exceptions properly.

  Show description for 60de2dc
  

  graememorgan

  authored and

  netdpb

  committed
  60de2dc

• Inspect TimeUnit.convert(Duration) for mismatches.

  Show description for 3eb5709
  

  nick-someone

  authored and

  netdpb

  committed
  3eb5709

• Reorder some Optional handling

  Show description for 4213c4a
  

  amalloy

  authored and

  netdpb

  committed
  4213c4a

• Improve handling of AutoCloseable

  Show description for f3fee80
  

  amalloy

  authored and

  netdpb

  committed
  f3fee80

• TryFailRefactoring: don't NPE if there's no enclosing method.

  Show description for 7040b51
  

  graememorgan

  authored and

  netdpb

  committed
  7040b51

• AbstractReturnValueIgnored: avoid recreating Matchers for each call; do some memoizing.

  Show description for b3e4fae
  

  graememorgan

  authored and

  netdpb

  committed
  b3e4fae

• StronglyTypeDuration: generalise to Instant, Joda types, and proto time.

  Show description for 3440c9a
  

  graememorgan

  authored and

  netdpb

  committed
  3440c9a

• Fix some Javadoc in StaticImports.

  Show description for d97e683
  

  graememorgan

  authored and

  netdpb

  committed
  d97e683

• Disable PreferJavaTimeOverload by default in Error Prone.

  Show description for 08c4793
  

  nick-someone

  authored and

  netdpb

  committed
  08c4793

• InterruptedExceptionSwallowed: handle try with resources better.

  Show description for b7f2a6e
  

  graememorgan

  authored and

  netdpb

  committed
  b7f2a6e

• Fix method reference void check.

  Show description for e7c3e3c
  

  graememorgan

  authored and

  netdpb

  committed
  e7c3e3c