Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hang in state_rebuilder for mid-execution capture of SaschaWillems pipelines example #2390

Closed
bjoeris opened this issue Nov 23, 2018 · 1 comment
Closed

Hang in state_rebuilder for mid-execution capture of SaschaWillems pipelines example #2390

bjoeris opened this issue Nov 23, 2018 · 1 comment
Assignees
@bjoeris

Comments

@bjoeris
Copy link
Contributor

bjoeris commented Nov 23, 2018

There is an infinite loop in getPipelinesInOrder
@bjoeris bjoeris self-assigned this Nov 23, 2018
bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 23, 2018
@bjoeris
Vulkan: Fix infinite loop in state_rebuilder.
75dc07b 
The problematic case is a state containing multiple pipelines, some of which
have 0 basePipeline, and some of which have a basePipeline that forms a loop or
doesn't exist. This caused both `numHandled` and `len(unhandledPipelines)` to be
non-zero forever. This change resets `numHandled` for each pass over
`unhandledPipelines`.

Fixes google#2390
@bjoeris bjoeris mentioned this issue Nov 23, 2018
Merged
@bjoeris
Copy link
Contributor Author

bjoeris commented Nov 23, 2018

The immediate symptom of the hang is fixed in #2391, but this leaves open the problem of loops in the BasePipelines. It appears that BasePipeline is not being set correctly from the GraphicsPipelineCreateInfo.

@bjoeris bjoeris mentioned this issue Nov 23, 2018
Closed
bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 23, 2018
@bjoeris
Vulkan: Fix infinite loop in state_rebuilder.
363e5a0 
The problematic case is a state containing multiple pipelines, some of which
have 0 basePipeline, and some of which have a basePipeline that forms a loop or
doesn't exist. This caused both `numHandled` and `len(unhandledPipelines)` to be
non-zero forever. This change resets `numHandled` for each pass over
`unhandledPipelines`.

Fixes google#2390
bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 24, 2018
@bjoeris
Vulkan: Fix infinite loop in state_rebuilder.
f60bf4d 
The problematic case is a state containing multiple pipelines, some of which
have 0 basePipeline, and some of which have a basePipeline that forms a loop or
doesn't exist. This caused both `numHandled` and `len(unhandledPipelines)` to be
non-zero forever. This change resets `numHandled` for each pass over
`unhandledPipelines`.

Fixes google#2390
bjoeris added a commit that referenced this issue Nov 26, 2018
@bjoeris
Vulkan: Fix infinite loop in state_rebuilder.
55b03c9 
The problematic case is a state containing multiple pipelines, some of which
have 0 basePipeline, and some of which have a basePipeline that forms a loop or
doesn't exist. This caused both `numHandled` and `len(unhandledPipelines)` to be
non-zero forever. This change resets `numHandled` for each pass over
`unhandledPipelines`.

Fixes #2390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoeris bjoeris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjoeris