Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasePipeline is set incorrectly #2392

Closed
bjoeris opened this issue Nov 23, 2018 · 1 comment
Closed

BasePipeline is set incorrectly #2392

bjoeris opened this issue Nov 23, 2018 · 1 comment
Assignees
@bjoeris

Comments

@bjoeris
Copy link
Contributor

bjoeris commented Nov 23, 2018 •
edited
Loading

Pipelines created with a base pipeline specified using basePipelineHandle create *PipelineObjects with incorrect BasePipeline.

This causes a loop in the BasePipeline graph, and is the ultimate cause of the infinite loop in #2390.
@bjoeris bjoeris self-assigned this Nov 23, 2018
bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 23, 2018
@bjoeris
Vulkan: Fix BasePipeline value set in vkCreate*Pipelines
0b3acbc 
When the `vk*PipelineCreateInfo` specifies a base pipeline by
`basePipelineHandle`, the `basePipelineIndex` is set to -1; the previous code
lost this -1 value, and later in `vk*PipelineCreateInfo`, `BasePipelineIndex`
was 0, causing `BasePipeline` to be set by index, instead of by handle.

This change ensures that `basePipelineIndex` is copied over to the
`*PipelineObject`, so that `BasePipeline` is set correctly.

Fixes google#2392
@bjoeris bjoeris mentioned this issue Nov 23, 2018
Merged
@bjoeris
Copy link
Contributor Author

bjoeris commented Nov 23, 2018

#2393 fixes the problem in vkCreate*Pipelines, but existing mid-execution captures that used basePipelineHandle will still have incorrect BasePipeline values.

bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 23, 2018
@bjoeris
Vulkan: Fix BasePipeline value set in vkCreate*Pipelines
3838a57 
When the `vk*PipelineCreateInfo` specifies a base pipeline by
`basePipelineHandle`, the `basePipelineIndex` is set to -1; the previous code
lost this -1 value, and later in `vk*PipelineCreateInfo`, `BasePipelineIndex`
was 0, causing `BasePipeline` to be set by index, instead of by handle.

This change ensures that `basePipelineIndex` is copied over to the
`*PipelineObject`, so that `BasePipeline` is set correctly.

Fixes google#2392
bjoeris added a commit to bjoeris/gapid that referenced this issue Nov 24, 2018
@bjoeris
Vulkan: Fix BasePipeline value set in vkCreate*Pipelines
c11df90 
When the `vk*PipelineCreateInfo` specifies a base pipeline by
`basePipelineHandle`, the `basePipelineIndex` is set to -1; the previous code
lost this -1 value, and later in `vk*PipelineCreateInfo`, `BasePipelineIndex`
was 0, causing `BasePipeline` to be set by index, instead of by handle.

This change ensures that `basePipelineIndex` is copied over to the
`*PipelineObject`, so that `BasePipeline` is set correctly.

Fixes google#2392
bjoeris added a commit that referenced this issue Nov 26, 2018
@bjoeris
Vulkan: Fix BasePipeline value set in vkCreate*Pipelines
2f14c6a 
When the `vk*PipelineCreateInfo` specifies a base pipeline by
`basePipelineHandle`, the `basePipelineIndex` is set to -1; the previous code
lost this -1 value, and later in `vk*PipelineCreateInfo`, `BasePipelineIndex`
was 0, causing `BasePipeline` to be set by index, instead of by handle.

This change ensures that `basePipelineIndex` is copied over to the
`*PipelineObject`, so that `BasePipeline` is set correctly.

Fixes #2392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoeris bjoeris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjoeris