Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux github workflow #722

Merged
merged 1 commit into from
Oct 11, 2021
Merged

add linux github workflow #722

merged 1 commit into from
Oct 11, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Oct 8, 2021

Since AppVeyor and Travis Builds ceased to work, this PR adds a corresponding Github workflow for testing glog under Ubuntu. This is a continuation of #720 with some changes reworked.

More specifically:

  • Use latest Google Test and Google Mock
  • Update the badges
  • Generate coverage

@drigz What options are there for coverage analysis? Can codecov or coveralls be enabled for the repo?

@sergiud sergiud added this to the 0.6 milestone Oct 8, 2021
@sergiud sergiud requested a review from drigz October 8, 2021 20:25
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@sergiud sergiud force-pushed the linux-github-action branch from 2dcd3b7 to 36d9c4c Compare October 9, 2021 09:52
@drigz
Copy link
Member

drigz commented Oct 11, 2021

Sorry, I'm afraid I've not used GitHub actions or any of those coverage tools before, my knowledge is all from the days of running make coverage and inspecting a text file...

@sergiud
Copy link
Collaborator Author

sergiud commented Oct 11, 2021

@drigz Is there someone who can enable Codecov for glog? Codecov is being used by some Google repos and coveralls is used by even more Google repos.

@drigz
Copy link
Member

drigz commented Oct 11, 2021

I couldn't find an explanation on how to do it, but I signed into coveralls.io and "enabled" this repo. I also found this doc about the GitHub Action: https://github.com/marketplace/actions/coveralls-github-action - is that sufficient for you to enable it here?

@sergiud
Copy link
Collaborator Author

sergiud commented Oct 11, 2021

@drigz Thanks! Enabling the coveralls github action should be sufficient.

@sergiud sergiud force-pushed the linux-github-action branch from 36d9c4c to 31e36a4 Compare October 11, 2021 12:57
@sergiud
Copy link
Collaborator Author

sergiud commented Oct 11, 2021

@drigz Seems to be working just fine now. Do we want notifications in PRs (e.g., as seen here)? In that case, read-only access to Coveralls bot should be given.

@sergiud sergiud force-pushed the linux-github-action branch from 31e36a4 to 5bea108 Compare October 11, 2021 13:22
@drigz
Copy link
Member

drigz commented Oct 11, 2021

I "invited" the bot, let's see if the comments appear.

@sergiud
Copy link
Collaborator Author

sergiud commented Oct 11, 2021

Possibly a new build must be triggered as well. Let me try that.

@sergiud sergiud force-pushed the linux-github-action branch from 5bea108 to 4a55b11 Compare October 11, 2021 13:54
@sergiud
Copy link
Collaborator Author

sergiud commented Oct 11, 2021

Looks like comments are only added if a baseline coverage exists which is currently not the case.

@sergiud sergiud merged commit 56d3fac into master Oct 11, 2021
@sergiud sergiud deleted the linux-github-action branch October 11, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants