-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linux github workflow #722
Conversation
2dcd3b7
to
36d9c4c
Compare
Sorry, I'm afraid I've not used GitHub actions or any of those coverage tools before, my knowledge is all from the days of running |
@drigz Is there someone who can enable Codecov for glog? Codecov is being used by some Google repos and coveralls is used by even more Google repos. |
I couldn't find an explanation on how to do it, but I signed into coveralls.io and "enabled" this repo. I also found this doc about the GitHub Action: https://github.com/marketplace/actions/coveralls-github-action - is that sufficient for you to enable it here? |
@drigz Thanks! Enabling the coveralls github action should be sufficient. |
36d9c4c
to
31e36a4
Compare
@drigz Seems to be working just fine now. Do we want notifications in PRs (e.g., as seen here)? In that case, read-only access to Coveralls bot should be given. |
31e36a4
to
5bea108
Compare
I "invited" the bot, let's see if the comments appear. |
Possibly a new build must be triggered as well. Let me try that. |
5bea108
to
4a55b11
Compare
Looks like comments are only added if a baseline coverage exists which is currently not the case. |
Since AppVeyor and Travis Builds ceased to work, this PR adds a corresponding Github workflow for testing glog under Ubuntu. This is a continuation of #720 with some changes reworked.
More specifically:
@drigz What options are there for coverage analysis? Can codecov or coveralls be enabled for the repo?