-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templated local parametrization for ceres #305
Templated local parametrization for ceres #305
Conversation
8dacb86
to
ef9a3ad
Compare
01b5c97
to
9797a01
Compare
574a7a7
to
2063e5e
Compare
2063e5e
to
7366e2d
Compare
@sergiud , are there any problems left? I have a Thanks |
Your PR looks good to me. @strasdat needs to review it. |
IMHO a second PR would be best (but I don't have any authority here). You could already open it, if you want, and note that it depends on this PR. Thanks for your contribution! This will be very useful. |
RxSO2::cast
/(Rx)SO3::operator*
in order to be compatible withceres::Jet
In order to work around a corner-case of
SO2::Tangent
beingScalar
(and notVector<Scalar, 1>
), helper traitis_mappable_type_v
is introduced (using completeness ofEigen::internal::traits<T>
, since just having::Scalar
type is not enough, sinceceres::Jet
has this type defined, but needs to be considered a scalar). This type trait is only needed for group-agnostic code and end-users do not need to use it.Added also a simple Lie-group averaging example (on a complete graph in order to simplify test data generation).