Allow kubectl global flags in ko apply #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 50.83% 50.57% -0.26%
==========================================
Files 63 63
Lines 2939 2954 +15
==========================================
Hits 1494 1494
- Misses 1196 1211 +15
Partials 249 249
Continue to review full report at Codecov.
|
jonjohnsonjr
force-pushed
the
kubectl-globals
branch
from
fe9b4f5
to
7c91c60
Compare
jonjohnsonjr
force-pushed
the
kubectl-globals
branch
from
7c91c60
to
139e54b
Compare
This registers the global flags with the kubectl apply command and passes them through to kubectl.
jonjohnsonjr
force-pushed
the
kubectl-globals
branch
from
139e54b
to
fa55feb
Compare
|
@mattmoor WDYT |
mattmoor
approved these changes
Nov 30, 2018
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288
Fixes #295