Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove k8s deps if possible #317

Closed
jonjohnsonjr opened this issue Feb 22, 2021 · 5 comments · Fixed by #413
Closed

Remove k8s deps if possible #317

jonjohnsonjr opened this issue Feb 22, 2021 · 5 comments · Fixed by #413

Comments

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Feb 22, 2021

I added these forever ago to get kubectl flags, but it's been a source of endless trouble...

See #315 (comment) for a recent issue.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@dprotaso
Copy link
Contributor

@jonjohnsonjr
Copy link
Collaborator Author

Can you elaborate a bit?

@dprotaso
Copy link
Contributor

dprotaso commented Jun 21, 2021

sigh - sorry wrong repo - I meant to link - https://github.com/kubernetes/cli-runtime - that pulls out some common cli logic - ie. flags & reading yaml files

but I realize it depends on k8s upstream libs as well and unfortunately with replace directives :(

@dprotaso
Copy link
Contributor

the replace directives match the versions in the require block so maybe it's just automation playing safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants