Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/cli-runtime from 0.20.6 to 0.22.0 #409

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2021

Bumps k8s.io/cli-runtime from 0.20.6 to 0.22.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) from 0.20.6 to 0.22.0.
- [Release notes](https://github.com/kubernetes/cli-runtime/releases)
- [Commits](kubernetes/cli-runtime@v0.20.6...v0.22.0)

---
updated-dependencies:
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 9, 2021
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@imjasonh
Copy link
Member

imjasonh commented Aug 9, 2021

This seems to bring in a dependency on io/fs, which requires Go 1.16. How do we feel about bumping the min required version needed to build ko, or vendor it?

@jonjohnsonjr
Copy link
Collaborator

I'd rather just drop it entirely, tbh.

@imjasonh
Copy link
Member

imjasonh commented Aug 9, 2021

I'd rather just drop it entirely, tbh.

Agreed -- is that #317 ? Or is that just having ko apply and ko delete passthru unknown flags to kubectl and failing if those aren't supported?

@jonjohnsonjr
Copy link
Collaborator

Aren't those the same? I'd honestly be fine with hard-coding whatever flags currently exist in the last ko release and passing only those through. Alternatively, we would spork genericclioptions so that it's just some flags?

@imjasonh
Copy link
Member

imjasonh commented Aug 9, 2021

#317 (comment) sounded like it was just proposing different packaging for the kubectl common flags, but I agree we should probably just drop them entirely. I'd rather not spork genericclioptions because I don't think it'll net us much.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 10, 2021

Looks like k8s.io/cli-runtime is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Aug 10, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/cli-runtime-0.22.0 branch August 10, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants