Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.17 compiler toolchain #1890

Closed
gmlewis opened this issue Jun 12, 2021 · 4 comments · Fixed by #1891
Closed

Support Go 1.17 compiler toolchain #1890

gmlewis opened this issue Jun 12, 2021 · 4 comments · Fixed by #1891

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 12, 2021

In #1889, a simple typo fix in the README.md file demonstrated that the Go 1.17 compiler toolchain is now modifying the formatting of // +build lines.

We will need to fix this before we are able to continue merging PRs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jun 12, 2021

@willnorris
Copy link
Collaborator

Should be as simple as adding the new syntax. From https://tip.golang.org/doc/go1.17:

As of this release, the new syntax is fully supported, and all Go files should be updated to have both forms with the same meaning.

@willnorris
Copy link
Collaborator

Though I'm very surprised that actions/setup-go is included a beta release for the "1.x" go version. I would expect that to be the latest stable release. I seem to recall running into this before, so will look into that separately.

@willnorris
Copy link
Collaborator

fixed the "1.x" stable release issue in 77dd0eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants