Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in readme in word "parameters" #1889

Closed
wants to merge 0 commits into from
Closed

Fix typo in readme in word "parameters" #1889

wants to merge 0 commits into from

Conversation

jansvabik
Copy link
Contributor

Resolves #1888. This pull request fixes the typo in README file mentioned in the corresponding issue.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 12, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jansvabik !
LGTM.
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 12, 2021

Whups! It looks like the compiler toolchain for Go 1.17 has made a breaking change that needs to be addressed before we can continue and merge this change. I'll file a separate issue.

@willnorris
Copy link
Collaborator

gah, not sure why that closed the PR. I was trying to rebase this on master. In any event, I'll get the correct commit merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in README
3 participants