Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository rulesets are missing the source attribute for the property condition #3247

Closed
anelam opened this issue Aug 22, 2024 · 5 comments · Fixed by #3250
Closed

repository rulesets are missing the source attribute for the property condition #3247

anelam opened this issue Aug 22, 2024 · 5 comments · Fixed by #3250

Comments

@anelam
Copy link

anelam commented Aug 22, 2024

Rulesets have a source attribute for the property condition to select if a custom or system property is used.
It is documented here.

It is missing in the RulesetRepositoryPropertyTargetParameters struct.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 22, 2024

Thank you, @anelam .

Would you like to create a PR, or shall I open this up to other contributors to this repo?

@anelam
Copy link
Author

anelam commented Aug 22, 2024

@gmlewis feel free to open this up to others.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 22, 2024

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@rezmoss
Copy link
Contributor

rezmoss commented Aug 22, 2024

@gmlewis I'd like to work on this

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 22, 2024

@gmlewis I'd like to work on this

Thank you, @rezmoss ! It's yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants