Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Source field to RulesetRepositoryPropertyTargetParameters #3250

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rezmoss
Copy link
Contributor

@rezmoss rezmoss commented Aug 26, 2024

Fixes: #3247.

@gmlewis gmlewis changed the title fixed #3247 Add Source field to RulesetRepositoryPropertyTargetParameters Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (53da04d).
Report is 104 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   97.72%   92.95%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11647    -1743     
==========================================
- Hits        13085    10826    -2259     
- Misses        215      727     +512     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rezmoss.
LGTM.
Merging.

@gmlewis gmlewis merged commit c96ef95 into google:master Aug 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repository rulesets are missing the source attribute for the property condition
2 participants