Skip to content

fix!: Remove ListOptions from PullRequestsService.ListReviewers#4009

Merged
gmlewis merged 2 commits intogoogle:masterfrom
maishivamhoo123:fix/list-reviewers-pagination
Feb 13, 2026
Merged

fix!: Remove ListOptions from PullRequestsService.ListReviewers#4009
gmlewis merged 2 commits intogoogle:masterfrom
maishivamhoo123:fix/list-reviewers-pagination

Conversation

@maishivamhoo123
Copy link
Contributor

@maishivamhoo123 maishivamhoo123 commented Feb 13, 2026

BREAKING CHANGE: PullRequestsService.ListReviewers no longer has opts *ListOptions.

Issue Related : #3976
This PR Remove the ListOptions argument from ListReviewers function signature as it doesn't supports pagination as mentioned in [https://docs.github.com/en/rest/pulls/review-requests?apiVersion=2022-11-28#get-all-requested-reviewers-for-a-pull-request](Get all Request Reviewer List Docs)

@gmlewis gmlewis changed the title fix(pulls):ListReviewers doesn't support pagination fix!: Add ListOptions to PullRequestsService.ListReviewers Feb 13, 2026
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (a8a36ab) to head (5e08a90).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
- Coverage   93.60%   93.60%   -0.01%     
==========================================
  Files         207      207              
  Lines       17834    17831       -3     
==========================================
- Hits        16693    16690       -3     
  Misses        939      939              
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title fix!: Add ListOptions to PullRequestsService.ListReviewers fix!: Remove ListOptions from PullRequestsService.ListReviewers Feb 13, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 13, 2026

Very interesting! This PR demonstrates that gen-iterators.go appears to only be targeting methods that have ListOptions or ListCursorOptions or NextPage or After in their own custom *Options structs!
I'll create an issue for this.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maishivamhoo123!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 13, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 13, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis merged commit 478bf36 into google:master Feb 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants