fix!: Remove ListOptions from PullRequestsService.ListReviewers#4009
fix!: Remove ListOptions from PullRequestsService.ListReviewers#4009gmlewis merged 2 commits intogoogle:masterfrom
ListOptions from PullRequestsService.ListReviewers#4009Conversation
ListOptions to PullRequestsService.ListReviewers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4009 +/- ##
==========================================
- Coverage 93.60% 93.60% -0.01%
==========================================
Files 207 207
Lines 17834 17831 -3
==========================================
- Hits 16693 16690 -3
Misses 939 939
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ListOptions to PullRequestsService.ListReviewersListOptions from PullRequestsService.ListReviewers
|
Very interesting! This PR demonstrates that |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @maishivamhoo123!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra
|
Thank you, @alexandear! |
BREAKING CHANGE:
PullRequestsService.ListReviewersno longer hasopts *ListOptions.Issue Related : #3976
This PR Remove the ListOptions argument from ListReviewers function signature as it doesn't supports pagination as mentioned in [https://docs.github.com/en/rest/pulls/review-requests?apiVersion=2022-11-28#get-all-requested-reviewers-for-a-pull-request](Get all Request Reviewer List Docs)