Skip to content

fix!: Remove ListOptions from PullRequestsService.ListReviewers #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 2 commits into from
Feb 13, 2026
Merged

fix!: Remove ListOptions from PullRequestsService.ListReviewers #4009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2b409
fix(pulls):ListReviewers doesn't support pagination
maishivamhoo123 Feb 13, 2026
5e08a90
Merge branch 'master' into fix/list-reviewers-pagination
maishivamhoo123 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions github/pulls_reviewers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,8 @@ func (s *PullRequestsService) RequestReviewers(ctx context.Context, owner, repo
// GitHub API docs: https://docs.github.com/rest/pulls/review-requests#get-all-requested-reviewers-for-a-pull-request
//
//meta:operation GET /repos/{owner}/{repo}/pulls/{pull_number}/requested_reviewers
func (s *PullRequestsService) ListReviewers(ctx context.Context, owner, repo string, number int, opts *ListOptions) (*Reviewers, *Response, error) {
func (s *PullRequestsService) ListReviewers(ctx context.Context, owner, repo string, number int) (*Reviewers, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/pulls/%v/requested_reviewers", owner, repo, number)
u, err := addOptions(u, opts)
if err != nil {
return nil, nil, err
}

req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
Expand Down
37 changes: 2 additions & 35 deletions github/pulls_reviewers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func TestListReviewers(t *testing.T) {
})

ctx := t.Context()
got, _, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1, nil)
got, _, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1)
if err != nil {
t.Errorf("PullRequests.ListReviewers returned error: %v", err)
}
Expand All @@ -227,40 +227,7 @@ func TestListReviewers(t *testing.T) {

const methodName = "ListReviewers"
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1, nil)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
return resp, err
})
}

func TestListReviewers_withOptions(t *testing.T) {
t.Parallel()
client, mux, _ := setup(t)

mux.HandleFunc("/repos/o/r/pulls/1/requested_reviewers", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testFormValues(t, r, values{
"page": "2",
})
fmt.Fprint(w, `{}`)
})

ctx := t.Context()
_, _, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1, &ListOptions{Page: 2})
if err != nil {
t.Errorf("PullRequests.ListReviewers returned error: %v", err)
}

const methodName = "ListReviewers"
testBadOptions(t, methodName, func() (err error) {
_, _, err = client.PullRequests.ListReviewers(ctx, "\n", "\n", 1, &ListOptions{Page: 2})
return err
})

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1, &ListOptions{Page: 2})
got, resp, err := client.PullRequests.ListReviewers(ctx, "o", "r", 1)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand Down
Loading