Calling +[GTMSessionUploadFetcher fetcherWithSessionIdentifier:] incorrectly returns GTMSessionFetcher #402
Comments
bhamiltoncx
added a commit
to bhamiltoncx/gtm-session-fetcher
that referenced
this issue
Sep 20, 2024
`+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]` is declared to return instancetype, so it should return `GTMSessionUploadFetcher*`. In reality, that method has no implementation in `GTMSessionUploadFetcher.m`, so it always returns `GTMSessionFetcher*`. That means calling `GTMSessionUploadFetcher`-only methods on the resulting object will crash, since they're not implemented. The method `+[GTMSessionUploadFetcher uploadFetcherForSessionIdentifier:]` is implemented to return the correct type, so this PR implements `+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]` to thunk through to that method. Fixes: google#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]is declared to returninstancetype, so it should returnGTMSessionUploadFetcher*.In reality, that method has no implementation in
GTMSessionUploadFetcher.m, so it always returnsGTMSessionFetcher*. That means callingGTMSessionUploadFetcher-only methods on the resulting object will crash, since they're not implemented.The method
+[GTMSessionUploadFetcher uploadFetcherForSessionIdentifier:]is implemented to return the correct type, so we can implement+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]to thunk through to that method.The text was updated successfully, but these errors were encountered: