Implement +[GTMSessionUploadFetcher fetcherWithSessionIdentifier:] #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]` is declared to return instancetype, so it should return `GTMSessionUploadFetcher*`. In reality, that method has no implementation in `GTMSessionUploadFetcher.m`, so it always returns `GTMSessionFetcher*`. That means calling `GTMSessionUploadFetcher`-only methods on the resulting object will crash, since they're not implemented. The method `+[GTMSessionUploadFetcher uploadFetcherForSessionIdentifier:]` is implemented to return the correct type, so this PR implements `+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]` to thunk through to that method. Fixes: google#402
|
We can ignore the visionOS failures. Github dropped the SDK from their runners and |
thomasvl
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]is declared to returninstancetype, so it should returnGTMSessionUploadFetcher*.In reality, that method has no implementation in
GTMSessionUploadFetcher.m, so it always returnsGTMSessionFetcher*. That means callingGTMSessionUploadFetcher-only methods on the resulting object will crash, since they're not implemented.The method
+[GTMSessionUploadFetcher uploadFetcherForSessionIdentifier:]is implemented to return the correct type, so this PR implements+[GTMSessionUploadFetcher fetcherWithSessionIdentifier:]to thunk through to that method.Fixes: #402