Skip to content

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 12, 2025

@Pankraz76
Copy link
Author

Considering the broken format what to ignore?

  • Format
  • Bugs
  • Issues
  • Flaws

Im not used to ignore. Projects like checkstyle and PMD leave not place for excuses like this.

Its not plugin away to fix the madness for everybody involved.

<version>6.15.0</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please lets avoid any further to fix the broken window. Now its free and the best moment, everything else will be much more expensive, as the bugs and flaws will not be ignored by anybody.

Some actually like to invest the effort, fixing things up.

@Pankraz76 Pankraz76 marked this pull request as ready for review August 12, 2025 07:51
@Pankraz76 Pankraz76 force-pushed the fix-RemoveUnusedPrivateMethods branch from d4b76af to 987da3b Compare August 12, 2025 07:52
@Pankraz76 Pankraz76 force-pushed the fix-RemoveUnusedPrivateMethods branch from 987da3b to a0d1502 Compare August 12, 2025 08:53
@Pankraz76 Pankraz76 changed the title Avoid private scope on writeReplace to be reachable for caller and be consistent overall Add rewrite support for RemoveUnusedPrivateMethods Aug 12, 2025
@cpovirk
Copy link
Member

cpovirk commented Aug 12, 2025

as in #7945 (comment)

@cpovirk cpovirk closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants