Skip to content

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 12, 2025

@Pankraz76 Pankraz76 marked this pull request as ready for review August 12, 2025 08:07
<version>6.15.0</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.maven.BestPractices</recipe>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For transparency:

its there to be silent until some corruption happens. So its kind of "no big deal" to integrate as its just some backup the dev teams defines on its own.

If you only pick the snapshot you again left behind not able to evolve as the recipe and rewrite will, so its up to each one to leverage the benefit of constant compliance.

The cost of carry outweighs the cost of refactoring to its ether a one time fix (with QA gate), or constantly fixing but never done.

@Pankraz76 Pankraz76 changed the title Apply maven.BestPractices Add maven.BestPractices Aug 12, 2025
@Pankraz76 Pankraz76 force-pushed the maven-BestPractices branch from b527149 to 7882d4d Compare August 12, 2025 08:12
@Pankraz76 Pankraz76 changed the title Add maven.BestPractices Add rewrite support for maven.BestPractices Aug 12, 2025
@cpovirk
Copy link
Member

cpovirk commented Aug 12, 2025

It sounds like this will remain a disagreement around the relative costs and benefits of these checks for our specific code base and build integration. If I think of anything to add to #7916 (comment) and #7930 (comment) in the future, I'll add it, but I think that's most of the story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants