draft-irtf-cfrg-vrf-06 #1346
draft-irtf-cfrg-vrf-06 #1346
Conversation
|
This pull request introduces 2 alerts when merging 1ae055a into 81611a7 - view on LGTM.com new alerts:
|
|
Note, this could make use of golang/go#34105 when it is implemented. |
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
==========================================
- Coverage 70.15% 69.49% -0.67%
==========================================
Files 58 57 -1
Lines 4329 4261 -68
==========================================
- Hits 3037 2961 -76
- Misses 877 886 +9
+ Partials 415 414 -1
Continue to review full report at Codecov.
|
| // | ||
| // http://www.secg.org/sec1-v2.pdf | ||
| // https://tools.ietf.org/html/rfc8032#section-5.1.3 | ||
| func SECG1Decode(curve elliptic.Curve, data []byte) (x, y *big.Int) { |
There was a problem hiding this comment.
65-94 lines are duplicate of core/crypto/vrf/p256/unmarshal.go:27-56 (from dupl)
| if aux.params.cofactor > 1 { | ||
| hx, hy = aux.params.ec.ScalarMult(hx, hy, []byte{aux.params.cofactor}) | ||
| } | ||
| return |
There was a problem hiding this comment.
naked return in func hashToCurveSimplifiedSWU with 98 lines of code (from nakedret)
| } | ||
| } | ||
|
|
||
| func BenchmarkProveECVRFP256SHA256SWUU(b *testing.B) { |
There was a problem hiding this comment.
197-218 lines are duplicate of core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_tai_test.go:197-218 (from dupl)
| } | ||
| } | ||
|
|
||
| func BenchmarkProveECVRFP256SHA256TAI(b *testing.B) { |
There was a problem hiding this comment.
197-218 lines are duplicate of core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu_test.go:197-218 (from dupl)
Golang implementation of https://datatracker.ietf.org/doc/draft-irtf-cfrg-vrf/
This will replace the implementation at
core/crypto/vrfcc @reyzin