Add Fuzzing to VRF #1512

gdbelvin · 2020-04-07T10:21:36Z

Fuzzing did, in fact, find a bug :-)

Depends on #1346

golangcibot · 2020-04-07T10:23:51Z

core/crypto/draft-irtf-cfrg-vrf-06/conversion.go

+//
+// http://www.secg.org/sec1-v2.pdf
+// https://tools.ietf.org/html/rfc8032#section-5.1.3
+func SECG1Decode(curve elliptic.Curve, data []byte) (x, y *big.Int) {


77-106 lines are duplicate of core/crypto/vrf/p256/unmarshal.go:27-56 (from dupl)

golangcibot · 2020-04-07T10:23:51Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu_test.go

+	}
+}
+
+func BenchmarkProveECVRFP256SHA256SWUU(b *testing.B) {


197-218 lines are duplicate of core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_tai_test.go:197-218 (from dupl)

golangcibot · 2020-04-07T10:23:52Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_tai_test.go

+	}
+}
+
+func BenchmarkProveECVRFP256SHA256TAI(b *testing.B) {


197-218 lines are duplicate of core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu_test.go:197-218 (from dupl)

golangcibot · 2020-04-07T10:23:52Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu.go

+	if aux.params.cofactor > 1 {
+		hx, hy = aux.params.ec.ScalarMult(hx, hy, []byte{aux.params.cofactor})
+	}
+	return


naked return in func hashToCurveSimplifiedSWU with 98 lines of code (from nakedret)

codecov · 2020-04-07T11:11:22Z

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files          55       55           
  Lines        4063     4063           
=======================================
  Hits         2795     2795           
  Misses        862      862           
  Partials      406      406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6115a89...e1e984c. Read the comment docs.

lgtm-com · 2020-04-07T11:18:16Z

This pull request introduces 3 alerts when merging db8e3f9 into 81611a7 - view on LGTM.com

new alerts:

3 for Useless assignment to local variable

golangcibot · 2020-04-07T11:25:34Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_tai.go

+	return generateNonceRFC6979(a.params.hash, sk, h)
+}
+
+<<<<<<< HEAD


expected declaration, found '<<' (from typecheck)

golangcibot · 2020-04-07T11:25:34Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_tai.go

+
+	// 5.  While H is "INVALID" or H is EC point at infinity:
+	var err error
+	for Hx == nil || err != nil || (zero.Cmp(Hx) == 0 && zero.Cmp(Hy) == 0) {


expected declaration, found 'for' (from typecheck)

golangcibot · 2020-04-07T11:25:34Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_hash2curve.go

+	"math/big"
+)
+
+var zero big.Int


zero redeclared in this block (from typecheck)

golangcibot · 2020-04-07T11:25:34Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_aux.go

+	"math/big"
+)
+
+var zero big.Int


other declaration of zero (from `typecheck`)

golangcibot · 2020-04-07T11:25:35Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_hash2curve.go

+// Output:
+// - `H` - hashed value, a finite EC point in G
+// - `ctr` - integer, number of suite byte, attempts to find a valid curve point
+func HashToCurveTryAndIncrement(v *ECVRFSuite, Y *PublicKey, alpha []byte) (Hx, Hy *big.Int, ctr uint) {


HashToCurveTryAndIncrement redeclared in this block (from typecheck)

golangcibot · 2020-04-07T11:25:41Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_nonce_test.go

+	}
+	m := []byte("sample")
+
+	if got, want := GenerateNonceRFC6979(hash, SK, m).Bytes(),


undeclared name: GenerateNonceRFC6979 (from typecheck)

golangcibot · 2020-04-07T11:25:41Z

core/crypto/draft-irtf-cfrg-vrf-06/suites.go

+		//    hLen - output length in octets of Hash; must be at least 2n
+		Hash: crypto.SHA256,
+		Conversions: Conversions{
+			Int2String: I2OSP, // RFC8017 section-4.1 (big endian representation)


cannot use I2OSP (value of type func(x *big.Int, rLen uint) []byte) as func(a uint, l uint) []byte value in struct literal (from typecheck)

golangcibot · 2020-04-07T11:25:41Z

core/crypto/draft-irtf-cfrg-vrf-06/suites.go

+			String2Point: SECG1Decode, // Section 2.3.4 of [SECG1]
+
+			// ArbitraryString2Point returns string_to_point(0x02 || h_string)
+			ArbitraryString2Point: ArbitraryString2Point,


undeclared name: ArbitraryString2Point (from typecheck)

golangcibot · 2020-04-07T11:25:41Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu.go

+	//   12.  H_prelim = arbitrary_string_to_point(int_to_string(final_x, 2n))
+	//        (note: arbitrary_string_to_point will not return INVALID by
+	//        correctness of Simple SWU)
+	hx, hy, _ = aux.ArbitraryStringToPoint(aux.IntToString(xFinal, uint(aux.params.n*2)))


cannot use xFinal (variable of type *big.Int) as uint value in argument to aux.IntToString (from typecheck)

golangcibot · 2020-04-07T11:25:42Z

core/crypto/draft-irtf-cfrg-vrf-06/ecvrf_p256_sha256_swu.go

+		cofactor:    1,
+		hash:        crypto.SHA256,
+	}
+	p256SHA256SWU.ECVRFParams.aux = p256SHA256SWUAux{


cannot use (p256SHA256SWUAux literal) (value of type p256SHA256SWUAux) as ECVRFAux value in assignment: wrong type for method IntToString (from typecheck)

lgtm-com · 2020-04-20T09:26:38Z

This pull request introduces 3 alerts when merging e1e984c into 6115a89 - view on LGTM.com

new alerts:

3 for Useless assignment to local variable

googlebot added the cla: yes label Apr 7, 2020

dep bot added the dependent label Apr 7, 2020

golangcibot reviewed Apr 7, 2020

View reviewed changes

gdbelvin force-pushed the vrf-fuzz branch 2 times, most recently from 487f8d5 to db8e3f9 Compare April 7, 2020 11:11

golangcibot reviewed Apr 7, 2020

View reviewed changes

gdbelvin added 22 commits April 20, 2020 10:03

Try and Increment aux

e565d54

test vectors

52e5f45

Private Key

191f838

VRF interface

cc41683

Early VRFParams

865d598

ArbitraryString2Point validation

705f502

GenerateNonceRFC6979

209cbf9

SuiteString

8d2422b

U and V test vectors

2ec93f0

Working VRF Prove

32f4832

ECVRFParams w/ HashPoints and Decode

fb7c342

Proof2Hash

37b7c8d

Verify

8eb2902

mv vectors test to tai test

8f315af

mv hash2curve to tai

e800ecd

linter nits

1b3c559

Use int2octets

c2ff72a

StringToPoint returns error

13550b5

SEG1Decode docs

c23e29f

Use byte for int_to_string(ctr, 1)

a811157

IntToString with *big.Int

7a63580

license conversion

94c23c8

gdbelvin added 7 commits April 20, 2020 10:15

license ecvrf tai

2f98525

ecvrf_p256_sha256_swu

4a18277

BenchmarkTests

dd56055

Fix proving bug

2a9312b

Fuzzer

d892e2e

go-fuzz-build corpus

12e0e57

more corpus

e1e984c

gdbelvin force-pushed the vrf-fuzz branch from db8e3f9 to e1e984c Compare April 20, 2020 09:22

gdbelvin closed this Jun 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Fuzzing to VRF #1512

Add Fuzzing to VRF #1512

gdbelvin commented Apr 7, 2020 •

edited

Loading

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

codecov bot commented Apr 7, 2020 •

edited

Loading

lgtm-com bot commented Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

golangcibot Apr 7, 2020

lgtm-com bot commented Apr 20, 2020

Add Fuzzing to VRF #1512

Add Fuzzing to VRF #1512

Conversation

gdbelvin commented Apr 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 7, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Apr 20, 2020

gdbelvin commented Apr 7, 2020 •

edited

Loading

codecov bot commented Apr 7, 2020 •

edited

Loading