Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change reverts
BuiltinFnName
enum.CC: @ZibingZhang
Details
BuiltinFnName
was introduced by #130 to constrain keys inBUILTIN_FUNCS
. I originally thought that it was useful, but after several development I realized that using raw string is more desirable:BUILTIN_FUNCS
rejects all strings that are not defined in theBuiltinFnName
, which is not a desirable behavior.constants.BuiltInFnName.EXP.value
rather than"exp"
. The identifier also involves the same stringEXP
with the function name, meaning that we eventually need to write the function name with longer prefix every time.References
Blocked by