Enable mypy #153
Merged
Enable mypy #153
+161
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is still failing, will fix it |
ShigekiKarita
approved these changes
Dec 7, 2022
|
It is because mypy is provided by the official, and has more audience than others. Other tools are also good though; so this is just kinda bike-shedding decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduces mypy as a new CI. Also fixes several typing errors discovered by the non-strict mode of mypy.
This change removes the deprecated
with_latex, which is no longer useful to support (especially with correct type hints).References
NA
Blocked by