Improve python github workflows #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyammer
force-pushed
the
py-improve-gh-workflows
branch
from
ce725c3 to
e9642f4
Compare
|
The resulting linux wheel is still not pip installable on ubuntu 20.04 (see #781), but this PR is a good clean up anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the python-related workflows and package build scripts:
.github/workflows/python-test-suite.ymlnow tests everything it can that does NOT need the wheels. This includes testing the magika rust binary and the magika python package.maturin.ymlis now THE GH workflow in which we build the wheels, test them, and upload them as artifacts.maturin.yml.build_python_package.pyscript; we build the wheels viamaturin.yml.